Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile for Flask app #9

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Add Dockerfile for Flask app #9

wants to merge 24 commits into from

Conversation

lockefox
Copy link

@lockefox lockefox commented Mar 18, 2018 •
edited

  • Reviews PEP8 compliance
  • Adds setup.py for packaging
    • Collects ALL requirements (not just Flask app ones)
  • Adds Dockerfile for serving Flask website + gunicorn
  • Moves scrap code into /scraps path, to be deleted?
  • Moves ipynb files into /notebooks path
  • Adds CONTRIBUTORS file to track authors
  • Converts README from markdown to re-structured text (Python preferred format)
  • Adds some useful TODO notes for future refactoring
  • Changes requests pattern for better stability

@lockefox
remaping top-level of project for packaging
b8bc321
@lockefox
adding tests/ and __init__.py for packaging
55faa83
@lockefox
adding requirements and pathing MANIFEST.in
85f180a
@lockefox
adding requirements for get_process_data
f1298ae
@lockefox
adding CONTRIBUTORS
d525a3a
@lockefox
PEP review: app.py
f9e110d
@lockefox
PEP review: helpers.py
6539a21
@lockefox
PEP review: make_map.py
bb2b2c6
@lockefox
PEP review mongo_ip and mongo_query_results
669c7fe 
Added exception for mongo queries to allow `"`
@lockefox
cleaning up pandas_table and tests.py. Added pandas_table to scripts
2702c6b
@lockefox
PEP review of webserver_get.py
cd68d62
@lockefox
moving notebooks into their own folder
942f80f
@lockefox
PEP review get_process_data
65a80fc
@lockefox
adding gunicorn launcher helpers
9cf740a
@lockefox
writing a generic Dockerfile
11acc9d
@lockefox
fixing ARGS->ARG
642782d
@lockefox
patching setup issues and improving requirements list
8fa3b2c
@lockefox
bugfixing boto requirement
838dca8
@lockefox
fixing launcher namespace
2e52f68
@lockefox
fixing namespaces
6847fcd
@lockefox
fixing namespace and global PEP notes
7b4a6a1
@lockefox
adding unidecode to requirements
a8fcf68
@lockefox
fixing namespace and docker recipe
2186da9
@lockefox
removing troublesome configs from dockerfile
7a16a5b
lockefox
lockefox commented Mar 18, 2018
View reviewed changes
setup.py
install_requires=[
'beautifulsoup4',
'boto3',
'python-dateutil~=2.6.0', # BUGFIX: boto3 vs python-dateutil==2.7.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longterm TODO: split app concerns between scraper/trainer/Flask. All apps share one requirements list.

Biggest imports slowing building down:

  • sklearn
  • beautifulsoup4
  • nltk

@lockefox
Copy link
Author

Should add to README:

..code-block: bash
    docker build -t fakenews_flask -f Dockerfile .
    docker run -d -p 5000:5000 fakenews_flask

@lockefox
Copy link
Author

lockefox commented May 7, 2018

merge me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lockefox