Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign GPUs to PEs based on node ID #169

Merged
merged 2 commits into from
May 9, 2024

Conversation

spencerw
Copy link
Member

@spencerw spencerw commented May 8, 2024

Currently, PEs only utilize a single GPU per physical node, even if multiple devices are available. With this change, the user can split a physical node into virtual nodes and each virtual node will utilize a different GPU.

Note that using virtual nodes in SMP mode with projections enabled currently causes a CUDA memory error. This issue, however, is unrelated to the changes in this PR.

Copy link
Member

@trquinn trquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a couple of explanatory comments:

  1. What we are doing (round-robin GPUs among virtual nodes)
  2. Why here (Has to happen on each PE, and this is a convenient charm Group constructor)

@trquinn trquinn merged commit b1d1f04 into N-BodyShop:master May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants