[cleanup][move] Remove unused cargo deps + minor removal of some more unused things

[tzakian]

Description

Ran cargo udeps to find unused Cargo dependencies and removed them, and then also found some unused private types, and removed those as well.

Test plan

CI

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sui-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2024 6:26pm

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
multisig-toolkit	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 6:26pm
sui-kiosk	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 6:26pm
sui-typescript-docs	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 6:26pm

[amnn]

This one is interesting -- perhaps indicative of a bigger issue?

[tnowacki]

Despite the name of the crate... the v2 version of move-abstract-interpreter does not contain the abstract interpreter lol. It is still in the move-bytecode-verifier crate. So this should be fine.

Why? Because this crate only exists in v2 because it is trying to pin a version of the CFG which was split out from the binary format into this versioned crate recently. The alternative was to do a lot of code moving/rewriting in the v* crates, which seemed undesirable.

[tzakian]

So had a bit of a poke around, and it looks fine -- the main thing is the move-abstract-interpreter in non-v2 has a number of other trait abstractions in absint.rs that this v2 crate does not have (e.g., trait AbstractDomain, trait TransferFunctions, trait AbstractInterpreter etc.). It's those abstractions which utilize the verifier meter in their type signatures.