Shared object congestion control stress test #17751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@halfprice is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
halfprice
force-pushed
the
zhewu/congestion-control-stress-test
branch
from
9e1f152
to
71317b8
Compare
halfprice
force-pushed
the
zhewu/congestion-control-stress-test
branch
from
2666aaa
to
191192f
Compare
halfprice
changed the title
mystenmark
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a stress test in simtest to test shared object congestion control. The test is a good catch for liveness issue related to shared object congestion control.
After creating the test, I manually added some liveness bugs in the code (e.g. do not remove deferred txn from root, which can cause checkpoint stall), and the test was able to catch such bugs.
It also found an existing bug that when checking txn objects for congestion, it doesn't check if the transaction contains shared object or not.
Test plan
The test created in this PR.
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.