[GraphQL] Add a separate timeout field in ServiceConfig for mutations #17742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-mysten
requested review from
amnn,
wlmyng,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@stefan-mysten is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
wlmyng
reviewed
May 15, 2024
| @@ -42,6 +44,13 @@ impl Extension for TimeoutExt { | |||
| next: NextParseQuery<'_>, | |||
| ) -> ServerResult<ExecutableDocument> { | |||
| let document = next.run(ctx, query, variables).await?; | |||
| let is_mutation = document | |||
There was a problem hiding this comment.
another noob q: parse_query and validation work on the entire request document right? Wouldn't the logic below set any query to is_mutation = True as long as one of the top-level operations is a mutation?
There was a problem hiding this comment.
Great question which made me think again about this. At least in the IDE, you cannot run both a query request and a mutation at the same time, so for mutations you have to specify mutation {executeTransactionBlock(args) {fields}}, so this would return True, and for a query { chainIdentifier } or just { chainIdentifier } would return false because the OperationType is Query.
amnn
approved these changes
May 15, 2024
There was a problem hiding this comment.
Nice! Left some comments on implementation details, but the core logic here is all good, thanks @stefan-mysten.
|
Deployment failed with the following error: |
stefan-mysten
force-pushed
the
gql_increase_timeout_for_mutations
branch
from
fe0a0cd
to
c103118
Compare
stefan-mysten
force-pushed
the
gql_increase_timeout_for_mutations
branch
from
16b5de4
to
fb661bb
Compare
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
May 17, 2024
…MystenLabs#17742) ## Description Increases the timeout for mutation requests. ## Test plan Updated existing tests to also include this `mutation` timeout case. ``` cargo nextest run --features pg_integration -- tests::test_timeout ```  --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: Increased the `timeout` value for when executing a transaction block. - [ ] CLI: - [ ] Rust SDK:
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
May 17, 2024
…MystenLabs#17742) ## Description Increases the timeout for mutation requests. ## Test plan Updated existing tests to also include this `mutation` timeout case. ``` cargo nextest run --features pg_integration -- tests::test_timeout ```  --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: Increased the `timeout` value for when executing a transaction block. - [ ] CLI: - [ ] Rust SDK:
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
May 17, 2024
…MystenLabs#17742) ## Description Increases the timeout for mutation requests. ## Test plan Updated existing tests to also include this `mutation` timeout case. ``` cargo nextest run --features pg_integration -- tests::test_timeout ```  --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: Increased the `timeout` value for when executing a transaction block. - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases the timeout for mutation requests.
Test plan
Updated existing tests to also include this
mutationtimeout case.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
timeoutvalue for when executing a transaction block.