[data ingestion] migrate analytics to data ingestion framework #17731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@phoenix-o is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
sadhansood
approved these changes
May 17, 2024
| self.update_to_next_epoch(epoch); | ||
| self.create_epoch_dirs()?; | ||
| self.reset()?; | ||
| let mut state = self.state.lock().await; |
There was a problem hiding this comment.
just curious: why does the state need to be locked if it can only be processed one at a time
There was a problem hiding this comment.
so although this specific case has a concurrency of 1, the framework doesn't make exceptions and requires workers to be thread-safe. So they could be canceled, cloned, and rescheduled in another thread. We do the same for the archival workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.