Remove consensus hash #17709
Remove consensus hash #17709
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
mystenmark
changed the title
…mit prologue contains the consensus commit hash
mystenmark
force-pushed
the
mlogan-remove-consensus-hash
branch
from
4cdeed8
to
90d78eb
Compare
| @@ -231,7 +241,6 @@ impl ConsensusStatsAPI for ConsensusStatsV1 { | |||
| #[derive(Serialize, Deserialize, Clone, Debug, Default, PartialEq, Eq)] | |||
| pub struct ExecutionIndicesWithStats { | |||
| pub index: ExecutionIndices, | |||
| pub hash: u64, | |||
There was a problem hiding this comment.
Should we keep this for db compatibility as well?
There was a problem hiding this comment.
ah, didn't notice they were both in the db
|
Right now the checkpoint fork message does not give very clear indication of which consensus subdag has the fork. We actually just used this log message to debug a crash recovery issue. Maybe wait a bit until we have better logging inside consensus for forks? |
sounds good! |
Apart from the enhanced logging I would suggest for us to implement the consensus_digest for Mysticeti before we remove the hash anyways. I just realised actually that we never did. |
The sui-side hash is no longer necessary now that the commit prologue contains the consensus commit hash. If consensus forks, we will immediately observe a checkpoint fork.