[7][15/n][enums/Move] Add flavor to serialized compiled module for versions >= 7 #17706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
18e2936
to
72e8a84
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
a54c659
to
772709d
Compare
tzakian
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat and
mystenmark
as code owners
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
72e8a84
to
df4c290
Compare
tzakian
removed request for
amnn,
emmazzz,
mystenmark,
suiwombat,
wlmyng and
stefan-mysten
dariorussi
approved these changes
May 14, 2024
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
df4c290
to
7d8b624
Compare
cgswords
reviewed
May 14, 2024
| @@ -19,6 +19,54 @@ use std::{ | |||
| mem::size_of, | |||
| }; | |||
|
|
|||
| // Static assertions about the encoding of the flavor into the version of the binary format. | |||
| const _: () = { | |||
There was a problem hiding this comment.
Is it worth naming this for easier debugging if the assertions ever fail?
There was a problem hiding this comment.
Probably not, but I'll add some more comments!
cgswords
reviewed
May 14, 2024
Comment on lines
+32
to
+39
| pub const FLAVOR_MASK: u32 = 0xFF00_0000; | ||
| pub const VERSION_MASK: u32 = 0x00FF_FFFF; | ||
| // The Sui flavor is 0x05 | ||
| pub const SUI_FLAVOR: u8 = 0x05; | ||
| const SHIFT_AMOUNT: u8 = 24; |
There was a problem hiding this comment.
I wonder if there is a more-canonical way to do this in Rust, since we're doing it a few places now.
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
772709d
to
20f3837
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
7d8b624
to
5bd35d7
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
20f3837
to
37ecf65
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
5bd35d7
to
55e29f0
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
37ecf65
to
3be561d
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
55e29f0
to
8685a36
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
3be561d
to
6fd1819
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
8685a36
to
51696a1
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
6fd1819
to
cb31954
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
51696a1
to
8b3f82b
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
cb31954
to
dc7301f
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
8b3f82b
to
d8fbeb9
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
dc7301f
to
415134a
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
d8fbeb9
to
fc81aec
Compare
tzakian
force-pushed
the
tzakian/move-enums-sui-tests
branch
from
415134a
to
343f4c1
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
fc81aec
to
ffa7cab
Compare
## Description Turns on enums in move 2024 alpha, and updates the location of tests to reflect that. ## Test plan Update existing tests, and make sure they pass. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed at the Move community meeting for versions of the Move binary format >= 7, we will start flavoring Sui serialized modules with the
0x05flavor flag.Test plan
Added additional tests to make sure versions are properly serialized (both with and without flavors), and that they are properly deserialized, or an error is thrown if a version >= 7 is supplied without a correct flavor.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.