Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sj201r5 #3108

Open
wants to merge 2 commits into
base: mark-ii/qa
Choose a base branch
from
Open

Sj201r5 #3108

wants to merge 2 commits into from

Conversation

ken-mycroft
Copy link
Contributor

Description

Adds support for the sj201r5 board. this device reverts to neopixels for LEDs and pwm GPIO for fan.

How to test

Install an sj201r5 board. Change the config file board type to sj201r5

Contributor license agreement signed?

CLA [Y ]

…neopixel and sudo python3 -m pip install --force-reinstall adafruit-blinka are required. also you will need to change config file to change default
@pep8speaks
Copy link

pep8speaks commented May 27, 2022

Hello @ken-mycroft! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:1: E302 expected 2 blank lines, found 1
Line 20:26: E231 missing whitespace after ','
Line 21:38: E231 missing whitespace after ','
Line 21:80: E501 line too long (84 > 79 characters)
Line 22:80: E501 line too long (82 > 79 characters)
Line 22:83: W291 trailing whitespace
Line 50:22: E201 whitespace after '('
Line 50:44: E202 whitespace before ')'
Line 53:20: E201 whitespace after '('
Line 53:27: E201 whitespace after '('
Line 53:43: E202 whitespace before ')'
Line 53:45: E202 whitespace before ')'
Line 56:80: E501 line too long (93 > 79 characters)
Line 69:1: W391 blank line at end of file

Line 20:1: E302 expected 2 blank lines, found 1
Line 62:80: E501 line too long (85 > 79 characters)
Line 79:80: E501 line too long (82 > 79 characters)
Line 83:5: E303 too many blank lines (2)

Comment last updated at 2022-05-27 17:05:35 UTC

@ken-mycroft ken-mycroft changed the base branch from dev to mark-ii/qa May 27, 2022 16:54
@synesthesiam synesthesiam removed their request for review January 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants