New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-3100 - Adding skills methods for padatious #3101
base: dev
Are you sure you want to change the base?
Conversation
Voight Kampff Integration Test Succeeded (Results) |
Hey there, thanks for helping to improve Mycroft! I can definitely see the appeal here. I'm tossing up in my mind whether a separate method is necessary or if we should check to see if the
Interested in any opinions on this. If we do go with a separate method, I'm wondering if we can find a more descriptive name. If I'm developing a Skill and see:
It's not immediately clear to me how they differ. I might also interpret the new method as if I'm going to register an intent file as something else. Would something like Edit: Just fyi I doubt the VK test failure reported above is related to this PR. |
The current methods allows the use of full path because of Home Assistant skill recently started using full path, but it fails in the end (see MycroftAI/skill-homeassistant#104) as padatious fails to save the network file:
Another solution may be to sanitize the path when generating the name to only keep the basename. However, I think some developpers will have trouble understanding why they fails to load The name |
Add two new skills methods to be able to load any file as padatious intent or entity. ==== Fixed Issues ==== Fix MycroftAI#3100 ==== Tech Notes ==== NONE ==== Documentation Notes ==== NONE ==== Localization Notes ==== NONE ==== Environment Notes ==== NONE ==== Protocol Notes ==== Add two new methods to skills to register padatious intents or entities even outside of `vocab` and `locale` directories
9b7d329
to
63a83b5
Compare
I force-pushed a new version with the proposed names |
Description
Add two new skills methods to be able to load any file as padatious
intent or entity, even outside of
vocab
andlocale
directories.Fix #3100
How to test
I also added unittests on
test_mycroft_skill.py
Contributor license agreement signed?
CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement