Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use response method for track_info handler #2974

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

krisgesling
Copy link
Contributor

Description

The audioservice.track_info handler was using a custom reply message, which is an older form of replying to a message.

This required you to know what the reply_type is eg:

response = self.bus.wait_for_response(
            Message('mycroft.audio.service.track_info'),
            reply_type='mycroft.audio.service.track_info_reply')

The new format is automatic:

response = self.bus.wait_for_response(
            Message('mycroft.audio.service.track_info'))

This is a breaking change as any calls expecting the custom reply_type will break. Creating the PR now so that we can switch it over in the next major release.

How to test

Using the new standard format of wait_for_response as above will currently result in no response being received. With this change, the reply conforms to the new standard and will be returned correctly.

@krisgesling krisgesling added the Breaking change PR contains breaking changes and should not be merged until the next major release is being prepared label Aug 11, 2021
@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Aug 11, 2021
@devops-mycroft
Copy link

devops-mycroft commented Aug 11, 2021

Voight Kampff Integration Test Succeeded (Results)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change PR contains breaking changes and should not be merged until the next major release is being prepared CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
No open projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

None yet

2 participants