New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for Basque language #2961
base: dev
Are you sure you want to change the base?
Conversation
Hello, @e-gor, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
Voight Kampff Integration Test Failed (Results). |
Hey Igor, this is awesome, thanks! For the new TTS and STT modules, we've created a plugin system so that these don't need to be merged and maintained in Mycroft-core. This means we aren't continually expanding core, and makes it easier to get fixes into individual packages. It also means you don't need to wait for merge requests like this to get in. We'll be extracting the existing modules out and making them their own plugin packages as well, just haven't gotten to that yet. Information on the plugin system is available here: and there's a complete TTS example here: So it will be easiest if this PR only contained translation additions. The Cheers |
So you mean I should take out the STT and TTS as modules? All right, but due to holidays, I do not think I will be able before September... Regarding |
Yeah that's right, it's not sustainable for us to push everything into mycroft-core. The plugins help keep mycroft-core lighter and make it quicker for maintainers to distribute fixes. Just for clarity I've added the PR to Lingua Franca as a dependency in this PR description. |
Is this plugin from the same user a valid example of a STT plugin? |
Yeah, that looks right. There's also more available on PyPI if you want some other examples: |
I have moved the Basque STT and TTS systems of Elhuyar to their own plugins: They have been tested and work properly. So now the PR only contains Basque translation additions and the |
Necessary changes in lingua-franca PRs done, @krisgesling. Once they are merged, this PR should have no conflict and could therefore be merged too. |
lingua-franca now has the nice_relative_time function (PR has been merged), but integration test still fails saying it does not exist, I do not know why... |
Hey Igor, we need to bump the Lingua Franca version to 0.4.3 in I tried to push this to your branch but understandably don't have write access. That should make the new function available, along with the rest of the Basque support. |
Sorry, my mistake (again), was not aware of that... Did the required change, but there are still errors in the integration tests (though I do not think they are due to our changes, they are in Wikipedia skill, apparently). |
Changes for Basque language
Description
These changes, along with those sent to other repos, make Mycroft work in Basque language.
Made by Elhuyar, Talaios and Skura
Type of PR
Feature implementation
Dependencies
This PR relies on MycroftAI/lingua-franca#206