Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PIP to 21.3.1 #2923

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Upgrade PIP to 21.3.1 #2923

wants to merge 2 commits into from

Conversation

krisgesling
Copy link
Contributor

@krisgesling krisgesling commented Jun 23, 2021

Description

Upgrade PIP to latest version.

There have been an extensive number of bugfixes, improvements and deprecations. Nothing that I've seen that should really impact us.

@forslund I remember hearing about issues with a previous PIP update - are there specific things you can remember that we should be on the lookout for?

Tested on:

  • Ubuntu 20.04 VM
  • Upgrading pip on an existing Mark II
  • Build of new Mark II image
  • Upgrading pip on an existing Mark 1

Contributor license agreement signed?

  • CLA

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jun 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2923 (8f5d9b1) into dev (7a9c762) will not change coverage.
The diff coverage is n/a.

❗ Current head 8f5d9b1 differs from pull request most recent head 2c0429e. Consider uploading reports for the commit 2c0429e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2923   +/-   ##
=======================================
  Coverage   52.62%   52.62%           
=======================================
  Files         123      123           
  Lines       11016    11016           
=======================================
  Hits         5797     5797           
  Misses       5219     5219           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9c762...2c0429e. Read the comment docs.

@devops-mycroft
Copy link

devops-mycroft commented Jun 23, 2021

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator

As long as the dev-setup.sh works as intended (delete .venv and do a fresh install of everything) it's ok. It's usually the .0 versions that has caused some regressions when installing some packages.

@vvstubbs
Copy link

vvstubbs commented Jun 23, 2021 via email

@krisgesling
Copy link
Contributor Author

Great, I'm going to push the change to the Mark II latest build for a few days just to be extra sure.

@vvstubbs thanks for reporting your experience too. In terms of Python3.9 there are a few issues we've seen at least with training the Padatious intents. So I wouldn't be using it in any production environment just yet.

@krisgesling krisgesling added this to Sprint 25: Core and Selene Bugfixes in Upcoming Sprints Aug 19, 2021
@krisgesling krisgesling removed this from Sprint 25: Core and Selene Bugfixes in Upcoming Sprints Aug 19, 2021
@krisgesling krisgesling changed the title Upgrade PIP from v20.0.2 > v21.1.2 Upgrade PIP to 21.3.1 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
No open projects
Status: Ready to merge
Development

Successfully merging this pull request may close these issues.

None yet

5 participants