New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added blackPanther support #2922
base: dev
Are you sure you want to change the base?
Conversation
Hello, @blackPantherOS, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
Voight Kampff Integration Test Succeeded (Results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for contributing to Mycroft!
I've sent you a copy of the CLA, and just had one question about this change below.
if [ -x /usr/bin/sudo ];then | ||
$SUDO installing git python3 python3-devel python3-pip python3-setuptools python3-virtualenv python-gobject3-devel libtool lib64ffi-devel openssl-devel autoconf bison swig glib2-devel portaudio-devel mpg123 mpg123-pulse screen curl pkgconfig lib64icu-devel automake lib64jpeg-devel lib64fann-devel gcc-c++ jq make | ||
else | ||
# own authentication without sudo | ||
installing git python3 python3-devel python3-pip python3-setuptools python3-virtualenv python-gobject3-devel libtool lib64ffi-devel openssl-devel autoconf bison swig glib2-devel portaudio-devel mpg123 mpg123-pulse screen curl pkgconfig lib64icu-devel automake lib64jpeg--devel lib64fann-devel gcc-c++ jq make | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that the else path on this conditional will ever be executed.
If sudo isn't on the system then the found_exe sudo
up around line 129 will fail and the script will exit. Have you tested this path out? I'm not at all familiar with this distro or the packaging manager it uses.
We do handle this better in Pako now, which is what we use for installing system packages for Skills etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok, because the blackPanther don't use sudo for authentication on the default installed system, but contain a wrapper on different path (the name is sudo), and system allows install sudo package if user want to this path: /usr/bin/sudo. Another way for 'detect', example if found_exe find it the autentication will not work on blackPanther OS. (or requires sudo install too)
Sorry I I'm too late for response, we work on many project in same time in our distro.
Description
(Description of what the PR does, such as fixes # {issue number})
The blackPanther OS support requires because the distro package names and package manager engine is different
How to test
(Description of how to validate or test this PR)
Simple function for package install if the dirstro is 'blackpantheros'
Contributor license agreement signed?
CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement
Signed already