Cleanup Adapt ContextManager implementation #2886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
the
Type: Refactoring and other improvements
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
added
the
Status: To be reviewed
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 1, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 1, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 1, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 1, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 5, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 5, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 5, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 6, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 6, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 6, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 7, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 7, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 7, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 7, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 7, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 9, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 9, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 9, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 9, 2021
cherry pick of MycroftAI#2886 Timed Context Manager Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
JarbasAl
reviewed
Aug 2, 2021
Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects _only_ the modifications done to integrate the context with the Mycroft intent system. The key differences from the default Adapt context manager are - Frames are timedout after a set time - get_context will only return the latest match - methods for removing context (all and specific)
forslund
force-pushed
the
refactor/adapt-context
branch
2 times, most recently
from
e05e323
to
c88f703
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2886 +/- ##
==========================================
- Coverage 52.85% 52.84% -0.02%
==========================================
Files 123 123
Lines 11043 11014 -29
==========================================
- Hits 5837 5820 -17
+ Misses 5206 5194 -12
Continue to review full report at Codecov.
|
forslund
force-pushed
the
refactor/adapt-context
branch
2 times, most recently
from
bc97282
to
c88f703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the Mycroft-core Adapt Context Manager depend on the ContextManager in Adapt. This removes a bunch of duplicated code. The current state of the class reflects only the modifications done to integrate the context with the Mycroft intent system. The handling of timeout has been moved into the earlier weird tuple-thing into the context frame metadata.
The key differences from the default Adapt context manager are
get_context()will only return the latest matchThis keeps the current implementation as-is, I need to dig into the history to see why point 2 was added and will be working to integrate some of the functionality in the context manager from adapt. (clear, remove and maybe a canonical way to limit the frame_stack)
I do however think this is a good first step.
How to test
Ensure unit tests still work, check that wikipedia skill "tell more" functionality works
Contributor license agreement signed?
CLA [ Yes ]