Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows skill to dynamically define intents or entities #3100

Open
zeronounours opened this issue Apr 24, 2022 · 0 comments · May be fixed by #3101
Open

Allows skill to dynamically define intents or entities #3100

zeronounours opened this issue Apr 24, 2022 · 0 comments · May be fixed by #3101

Comments

@zeronounours
Copy link

Is your feature request related to a problem? Please describe.
Some skills my require dynamic definition of padatious entities to prevent matching requests intented for other skills.
See MycroftAI/skill-homeassistant#64 and MycroftAI/skill-homeassistant#104

It can currently be done with file within resource directories, but it is not a clean solution.

Describe the solution you'd like
New methods should be implemented to dynamically load new entities or intents in padatious with any wanted name. For instance:

   def register_entity_file_as(self, filename, name):

Describe alternatives you've considered
Currently skill-homeassistant provides absolute path to a temporary file to MycroftSkill.register_entity_file(). This method may be updated to only use as name the base name of the file and not the full path.

zeronounours added a commit to zeronounours/mycroft-core that referenced this issue Apr 25, 2022
Add two new skills methods to be able to load any file as padatious
intent or entity.

==== Fixed Issues ====
Fix MycroftAI#3100

====  Tech Notes ====
NONE

====  Documentation Notes ====
NONE

==== Localization Notes ====
NONE

==== Environment Notes ====
NONE

==== Protocol Notes ====
Add two new methods to skills to register padatious intents or entities
even outside of `vocab` and `locale` directories
zeronounours added a commit to zeronounours/mycroft-core that referenced this issue Apr 29, 2022
Add two new skills methods to be able to load any file as padatious
intent or entity.

==== Fixed Issues ====
Fix MycroftAI#3100

====  Tech Notes ====
NONE

====  Documentation Notes ====
NONE

==== Localization Notes ====
NONE

==== Environment Notes ====
NONE

==== Protocol Notes ====
Add two new methods to skills to register padatious intents or entities
even outside of `vocab` and `locale` directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant