Enable nullable attributes in MvxRecyclerView lib #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheesebaron
added
t/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
Potential null refs
🆕 What is the new behavior (if this is a feature change)?
Enabled nullable attributes and handled null warnings.
Also fixed event in
IMvxRecyclerAdapterBindableHolderreturning action, which is not not how events work, just using regular EventHandler instead.💥 Does this PR introduce a breaking change?
Yes, See changes above
🐛 Recommendations for testing
You could run the Droid playground and check out the collectionview sample
📝 Links to relevant issues/docs
🤔 Checklist before submitting