Combiners registration via Setup.FillValueCombiners() override

[snechaev]

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature

⤵️ What is the current behavior?

There is no easy way to register ValueCombiner. The only way is to provide a custom implementation of BindingBuilder, which seems like overkill for such a task.

🆕 What is the new behavior (if this is a feature change)?

This PR adds the FillValueCombiners(IMvxValueCombinerRegistry registry) overload to the platform-specific Setup classes (MvxIosSetup, MvxMacSetup, etc.). This behaves the same way as the void FillValueConverters(IMvxValueConverterRegistry registry) for the converters. This gives the user with exactly the same experience as the for converters (except the naming-convention-based autoregistration, which was considered problematic from a performance point of view). With this overload, the developer able to easily register the combiners, either manually one-by-one or with assembly-scan or whatever.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Nothing special, but worth remembering that name in the registration process should be without suffixes and prefixes. For example, for the MvxMySuperValueCombiner the name MySuper should be used during registration.

📝 Links to relevant issues/docs

#4371

🤔 Checklist before submitting

• All projects build
• Follows style guide lines (code style guide)
• Relevant documentation was updated (docs style guide)
• Rebased onto current develop

[snechaev]

The dotnet format check failed on files that have not changed in the current PR. I don't think that it is a good idea to fix the formatting in the files that are unrelated to the this PR and include such a changes in the PR.

[Cheesebaron]

Build is failing:

D:\a\1\s\MvvmCross\Platforms\Wpf\Core\MvxWpfSetup.cs(139,51): error CS0246: The type or namespace name 'IMvxValueCombinerRegistry' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\MvvmCross.Wpf\MvvmCross.Platforms.Wpf.csproj

Looks good to me otherwise.

[snechaev]

Sorry, I did not noticed that Windows projects are not built on Mac hosts at least with the simplified build process (EnableWindowsTargeting=true). The build is now fixed. No changes other than the missing usings have been introduced.

[Cheesebaron]

Thanks!