Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved MvxFragmentExtensions.FindAssociatedViewModelType exception messages #4602

Merged
merged 1 commit into from
May 12, 2023

Conversation

ErisApps
Copy link
Contributor

@ErisApps ErisApps commented May 12, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Resolves #4601 by improving said exception messages.

⤵️ What is the current behavior?

Exception messages don't contain the type that actual caused the exception.

🆕 What is the new behavior (if this is a feature change)?

Exception messages do contain the type that actual caused the exception.

💥 Does this PR introduce a breaking change?

Not that I'm aware

🐛 Recommendations for testing

None

📝 Links to relevant issues/docs

Fixes #4601

🤔 Checklist before submitting

@ErisApps
Copy link
Contributor Author

@dotnet-policy-service agree

@Cheesebaron
Copy link
Member

Thanks!

@Cheesebaron Cheesebaron merged commit 662e331 into MvvmCross:develop May 12, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Improve MvxFragmentExtensions.FindAssociatedViewModelType exception messages.
2 participants