Bugfix: MvxFragmentPresentationAttribute.FragmentContentId misses "Android.Resource.Id.Content" #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
Cheesebaron
requested changes
Apr 28, 2023
|
I would appreciate if you made style changes separate from fixes in the future. Makes it much easier to review what is going on. Thanks for submitting a PR to fix this issue 😀 |
Cheesebaron
approved these changes
Apr 28, 2023
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix #4586
MvxFragmentPresentationAttribute.FragmentContentId has default value "0" when not explicitly initialized.
🆕 What is the new behavior (if this is a feature change)?
MvxFragmentPresentationAttribute.FragmentContentId has default value "Android.Resource.Id.Content".
💥 Does this PR introduce a breaking change?
No
🤔 Checklist before submitting