[WIP] Permission plugin #83
base: master
Are you sure you want to change the base?
Conversation
Cheesebaron
commented
Mar 29, 2016
- Create wrapper around @jamesmontemagno's Permission plugin
- Update nuspecs with dependency on this new plugin
- Use plugin in relevant plugins
{ | ||
public class MvxPermissions : IMvxPermissions | ||
{ | ||
public Task<bool> ShouldShowRequestPermissionRationaleAsync(Permission permission) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be async await?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to create an unnecessary context sync / wrap I believe, just pass the Task
to the caller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing wrong with this. No need to await it here, you can just pass the task along.
Is there a list available of which plugins need this? |
As far as I gather these need it. |
Hello, |
Any reason why to have a wrapper around it and not just use mine? @danieleardissone check: https://github.com/jamesmontemagno/PermissionsPlugin |
The wrapper is just to register yours with the IoC and official MvvmCross classes usually contain Mvx smurf naming. |
ah gotcha gotcha 👍 thanks @Cheesebaron |
@Cheesebaron Right now I do have a dependency on CurrentActivity... wondering if we can re-work that at all perhaps so it is easier to integrate with MvxPlugin Wrappers? |
@jamesmontemagno is your plugin working properly with Storage Permissions? |
Do you have the permission in your manifest as well? |
@Cheesebaron yes of course, in my manifest I have READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. |
@Cheesebaron isn't It would be good if we can create a sample app for implementing permissions in application ? |
Well, as the title says this is Work In Progress (WIP). I haven't had time to look into it further. If you want to hurry the process you are very welcome to do so. |
For your information I solved it. |
# Conflicts: # MvvmCross.Plugins.sln
…nging wrapped plugin.
Is there a specific reason why you couldn't just use my plugin? Why is there a need for a wrapper around it? Seems like it may get out of date if I am updating it. |