Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and improve WorldGroup. #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor and improve WorldGroup. #427

wants to merge 1 commit into from

Conversation

benwoo1110
Copy link
Member

@benwoo1110 benwoo1110 commented Feb 28, 2021 •
edited by nicegamer7

While doing PR #425, I saw possible improve in WorldGroup class, namely in:

  • Modifying
  • Saving to data source
  • HashSet storing worlds

The real changes are really only in WorldGroup and new WorldsSet classes.

@benwoo1110 benwoo1110 added the PR: Better Coding Improvements in code, but not introducing new features. label Feb 28, 2021
@benwoo1110 benwoo1110 added this to In Progress in Final 4.X Releases via automation Feb 28, 2021
@benwoo1110 benwoo1110 added the State: Needs Review By Dev Pull requests requires the approve of lead dev. label Feb 28, 2021
@benwoo1110 benwoo1110 mentioned this pull request Feb 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Better Coding Improvements in code, but not introducing new features. State: Needs Review By Dev Pull requests requires the approve of lead dev.
Projects
Final 4.X Releases
  
In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benwoo1110