Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACF Command rework - Done! #413

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

ACF Command rework - Done! #413

wants to merge 35 commits into from

Conversation

benwoo1110
Copy link
Member

@benwoo1110 benwoo1110 commented Dec 29, 2020 •
edited

This PR reworks Multiverse-Inventories commands to complement the changes from Multiverse/Multiverse-Core#2514.

Some things to note:

  • Remove reload command as its already done with /mv reload
  • Fix unit test to accommodate for new acf depdenency, just like mv-core.
  • Add getMapKeys method in Sharables to get all possible shares used for tab-complete.
  • Add commons-lang and guava dependency as provided bcu for some reason it said it was missing on compile.
  • No command syntax changes.

You can get the test builds at https://ci.benergy10.dev/

@benwoo1110
Ignore test for now.
f2b3efb
@benwoo1110
Prepare mv-inventories for ACF intergration.
158b81c
@benwoo1110
Add group command.
b4f26a3
@benwoo1110
Add toggle command.
b6c3178
@benwoo1110
Improve toggle command with context and condtion.
7b5fd51
@benwoo1110
Add create and delete group command.
2fcaf51
@benwoo1110
Update mv-core dependency.
a666bf6
@benwoo1110
Cleanup plugin.yml
d25c2b7
@benwoo1110
Add root command.
04d408f
@benwoo1110
Add world commands.
cf7df87
@benwoo1110
Fix world commands.
471d216
@benwoo1110
Add method in Sharables to get lookup map.
27ba4e2
@benwoo1110
Add shares commands.
f202f2b
@benwoo1110
Update mv-core dependency,
646a83b
@benwoo1110
Use new registerSubModule method.
6f91723
@benwoo1110
Add syntax and descriptions to params.
d615d06
@benwoo1110
Add com.google.guava dependency.
dca924b
@benwoo1110
Add commons-lang dependency.
8726cc7
@benwoo1110
Add import command.
a545898
@benwoo1110
Add migrate command.
a0585ec
@benwoo1110
Add spawn command.
dfde8cd
@benwoo1110
Add info command.
ba8c901
@benwoo1110
Add list command.
41605f6
@benwoo1110
Cleanup and remove old command code.
c8dff4f
@benwoo1110
Merge branch 'main' into acf
b7ffcab
@benwoo1110
Add package-info.
09aa044
@benwoo1110
Implement mocking test for ACF.
9bbfd34
@benwoo1110 benwoo1110 changed the title ACF Command rework - Almost done! ACF Command rework - Done! Dec 29, 2020
@benwoo1110 benwoo1110 mentioned this pull request Feb 9, 2021
Open
@benwoo1110 benwoo1110 added PR: Enhancement Pull requests to implement a feature or improvement in code. State: Needs Review By Dev Pull requests requires the approve of lead dev. 5.0.0 Next major release. labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumptruckman dumptruckman Awaiting requested review from dumptruckman

@nicegamer7 nicegamer7 Awaiting requested review from nicegamer7

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
5.0.0 Next major release. PR: Enhancement Pull requests to implement a feature or improvement in code. State: Needs Review By Dev Pull requests requires the approve of lead dev.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benwoo1110