Improve world regeneration command. #2799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to keep when deleting a world.
benwoo1110
requested changes
Aug 15, 2022
There was a problem hiding this comment.
Haven't tested yet, but here are some pointers based on looking at the code changes.
@nicegamer7 @zax71, if you all happen to have time, can help to try it out.
src/main/java/com/onarandombox/MultiverseCore/enums/KeepWorld.java
Outdated
Show resolved
Hide resolved
src/main/java/com/onarandombox/MultiverseCore/api/MVWorldManager.java
Outdated
Show resolved
Hide resolved
- Add an overload method for choosing what to delete in MVWorldManager#deleteWorld - Deprecated deleteWorld method - Renamed KeepWorld to WorldDeleteMode
If you do `/mv regen worldName -s --keep-gamerules`, the plugin will think that "--keep-gamerules" is a seed we're supplying. That shouldn't happen.
|
hi |
|
We are trying to get development back on track internally. As soon as we can review the code as a team this will get merged :) |
|
thanks sir |
|
Any update in this case? I would greatly appreciate this improvement :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2783, also fixes an unwanted behaviour where the spawn on regenerated worlds stays the same when providing a new seed.
When fixing #2783, I don't know if I'm allowed to modify the classes in the API package. If this shouldn't happen, we could always make the
deleteWorldFolderboolean to keep the paper config instead of deleting all files in the directory if set to false.