This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Fix memory management for static block variables in UIAlertView+MKBlockAdditions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +70,11 @@ + (void)alertView:(UIAlertView*) alertView didDismissWithButtonIndex:(NSInteger) | |||
| { | |||
| _dismissBlock(buttonIndex - 1); // cancel button is button 0 | |||
| } | |||
|
|
|||
| [_cancelBlock release]; | |||
There was a problem hiding this comment.
I'm getting errors on these lines:
UIAlertView+MKBlockAdditions.m:108:6: Use of undeclared identifier '_cancelBlock'
UIAlertView+MKBlockAdditions.m:109:5: Unknown type name '_cancelBlock'; did you mean 'CancelBlock'?
|
I think that should probably be: |
|
Yeah so it looks like pull request #7 made those into dynamic properties. I'm not sure if your change is still necessary but it should probably become something more like what I showed above. |
|
Okay I rebased your commit and fixed that: drewish@1994aa5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If objects referenced in the blocks are deallocated, in the next invocation of alertViewWithTitle:message:cancelButtonTitle:otherButtonTitles:onDismiss:onCancel: block arguments still reference to deallocated instances causing crash.
Fix the case if more than one UIAlertView is shown using block-based category method.
Add thread safety.