Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Windowed fullscreen showing the taskbar #5239

Conversation

Khaled-Dridi
Copy link
Contributor

Contains

this PR fixes #5228 when windowed fullscreen is pressed ir will still show the task bar i fix that buy making it double click the windowed full screen so wit will change its state twice

How to test

go to setting go to video change to windowed then change to windowed fullscreen
because previously when you press windowed then press windowed fullscreen it will keep the task bar

Outstanding before merging

If anything. You can use neat checkboxes! Feel free to delete if not needed

  • [no ] Need to consider use case x
  • [no ] Still have to adjust the wiki doc
  • [no ] Will need translation work

Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suprisingly, this works, although it does lead to a longer delay when switching screen modes.

There are a few things that I think could be improved here:

@Khaled-Dridi Khaled-Dridi closed this by deleting the head repository May 4, 2024
@Khaled-Dridi
Copy link
Contributor Author

Suprisingly, this works, although it does lead to a longer delay when switching screen modes.

There are a few things that I think could be improved here:

hi i just did that can you check it #5243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on trying to change display settings to windowed fullscreen
2 participants