chore(behavior): remove some CoreRegistry usage #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
keturn
force-pushed
the
chore/bhvrCoreRegistry
branch
from
a4e1b84
to
925d16e
Compare
|
Code-wise this looks fine, however on testing it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the CoreRegistry usage from
logic.behavior, though not all of it.Actioninstances get fields injected by BehaviorTreeBuilder, but I don't think the same is true ofBehaviorNodeorActor, so there are still some places in there using the global.I don't know whether this ends up helping #5004.