Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot. #654

Mystic-Slice · 2022-03-02T17:13:53Z

Description

Rubble created from destroying asteroid also now create smaller pieces when destroyed.
CreatesRubbleOnDestruction component is not added for tiny rocks.
DropsMoneyOnDestruction component added to rubble also except the tiny rocks.

Testing

Break the golden asteroid.

Observe that it does not collapse into tiny pieces of rocks straight away. Instead, it acts like normal asteroids in the game.

The smaller pieces when broken also drop loot.

P.S: The newly created pieces of asteroid do not break(fixed in #653). To test, add the health component to the rubble entities.

Pre Pull Request Checklist:

Code has been scanned with SonarLint
There are no errors present in the project
Code has been formatted and indented
Methods have appropriate Javadoc (How to write Javadoc)

BenjaminAmos

I haven't tested this yet but a few things caught my eye whilst looking through the changes.

BenjaminAmos · 2022-03-02T19:27:38Z

engine/src/main/java/org/destinationsol/rubble/systems/RubbleCreationSystem.java

@@ -146,6 +147,12 @@ private void buildRubblePieces(Position pos, Velocity vel, Angle angle, Size siz

            EntityRef entityRef = entitySystemManager.getEntityManager().createEntity(graphicsComponent, positionComponent,
                    velocityComponent, angle, sizeComponent, new RubbleMesh());
+
+            if(sizeComponent.size > 0.1) {


You might want to move the 0.1 value into a MIN_DIVISIBLE_SIZE constant. I wasn't clear on why that value was chosen until I realised what it was.

BenjaminAmos · 2022-03-02T19:34:01Z

engine/src/main/java/org/destinationsol/rubble/systems/RubbleCreationSystem.java

@@ -136,7 +137,7 @@ private void buildRubblePieces(Position pos, Velocity vel, Angle angle, Size siz

            //Create size component
            Size sizeComponent = new Size();
-            sizeComponent.size = scale;
+            sizeComponent.size = scale * size.size;


GitHub doesn't let me comment on unchanged lines but you forgot to multiply by the parent size on line 129.

DestinationSol/engine/src/main/java/org/destinationsol/rubble/systems/RubbleCreationSystem.java

Lines 128 to 130 in 52d2b8c

Vector2 position = new Vector2();

SolMath.fromAl(position, velocityAngle, SolRandom.randomFloat(size.size));

position.add(basePos);

Why not create a local variable to store the scaled size?

float scaledSize = scale * size.size;

You can then use that variable everywhere where you are currently using scale * size.size.

Mystic-Slice · 2022-03-03T03:40:56Z

@BenjaminAmos Thnkx for the review. I have made the corrections.

…d then into tiny rocks. The smaller pieces also drop loot when destroyed.

Mystic-Slice · 2022-03-04T01:07:27Z

Rebased to develop

BenjaminAmos

The fix works and the changes seem reasonable to me. I've never seen rubble as large as this before! I'll approve this but will wait for another review if possible, since I'm not too familiar with this area of the code,

Mystic-Slice force-pushed the RubbleSizeCount branch 4 times, most recently from 8f0cbdf to 52d2b8c Compare March 2, 2022 17:25

Mystic-Slice changed the title ~~fix #617(iii): Asteroids break into smaller pieces and then into tiny rocks~~ fix #617(iii, iv): Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot. Mar 2, 2022

BenjaminAmos reviewed Mar 2, 2022

View reviewed changes

Mystic-Slice changed the title ~~fix #617(iii, iv): Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot.~~ Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot. Mar 3, 2022

Mystic-Slice added 2 commits March 4, 2022 06:31

fix MovingBlocks#617(iii, iv): Asteroids break into smaller pieces an…

e2900e3

…d then into tiny rocks. The smaller pieces also drop loot when destroyed.

Code fixes

58cbfde

Mystic-Slice force-pushed the RubbleSizeCount branch from a27f01d to 58cbfde Compare March 4, 2022 01:06

BenjaminAmos approved these changes Mar 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot. #654

Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot. #654

Mystic-Slice commented Mar 2, 2022 •

edited

BenjaminAmos left a comment

BenjaminAmos Mar 2, 2022

BenjaminAmos Mar 2, 2022 •

edited

Mystic-Slice commented Mar 3, 2022

Mystic-Slice commented Mar 4, 2022

BenjaminAmos left a comment

	Vector2 position = new Vector2();
	SolMath.fromAl(position, velocityAngle, SolRandom.randomFloat(size.size));
	position.add(basePos);

Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot. #654

Are you sure you want to change the base?

Asteroids break into smaller pieces and then into tiny rocks. Small pieces drop loot. #654

Conversation

Mystic-Slice commented Mar 2, 2022 • edited

Description

Testing

Pre Pull Request Checklist:

BenjaminAmos left a comment

Choose a reason for hiding this comment

BenjaminAmos Mar 2, 2022

Choose a reason for hiding this comment

BenjaminAmos Mar 2, 2022 • edited

Choose a reason for hiding this comment

Mystic-Slice commented Mar 3, 2022

Mystic-Slice commented Mar 4, 2022

BenjaminAmos left a comment

Choose a reason for hiding this comment

Mystic-Slice commented Mar 2, 2022 •

edited

BenjaminAmos Mar 2, 2022 •

edited