Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Donate Button #111

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AristurtleDev
Copy link
Contributor

@AristurtleDev AristurtleDev commented Feb 26, 2024

Description

This PR adjusts the donate link in the navigation header to stand out more by presenting it as button style, right-aligning it within the navigation menu, and adding an effect on hover that makes the heart icon pulse.

Preview

donate_button_heart_pulse.mp4

Related Issues

This is in response to #74

Since the donate link will need to be customized, removing it from the site navigation json since these links are auto generated and we need to customize the donate button.
@AristurtleDev AristurtleDev marked this pull request as draft February 26, 2024 15:44
@AristurtleDev
Copy link
Contributor Author

@tomspilman regarding this PR, I've hit a bit of a snag due to docfx.

Since there's full control over the website part generated by 11ty, I can do what I need with the donate button as shown above. However, the documentation stuff generated by docfx dynamically builds the navigation bar through a JS script on page load. This means I can't override the template directly to place it right-justified like on the main page part.

However, within what I can do with docfx's templates, I can add it manually outside the script but it will be pushed all the way to the end, after the theme switch toggle.

image

If moving the donate button here is fine, I can make that adjustment and push it up, but it would need to be pushed here on both the main site and documentation sites to maintain consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant