New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reference Assembly Packages. #8274
Open
dellis1972
wants to merge
18
commits into
MonoGame:develop
Choose a base branch
from
dellis1972:refnuget
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6d66dbb
Add Reference Assembly Packages.
dellis1972 61a4333
Fix the package path to use TargetFramework
dellis1972 e3a862f
Update Java, hopefully fix linux build
dellis1972 d166856
try this
dellis1972 af6c230
ff
dellis1972 54cac7b
try setting the AndroidSdkDirectory
dellis1972 eeaee19
ff
dellis1972 0637318
ff
dellis1972 bb32c61
Back out android on linux changes
dellis1972 7734c66
Back out android on linux changes
dellis1972 8dadea7
fix linux build ?
dellis1972 6350382
only export public types
dellis1972 ab35211
add DevelopmentDependency
dellis1972 93ff311
update templates
dellis1972 9793be8
just use reference assemblies. rename atrifacts
dellis1972 a509778
accpet licences
dellis1972 0e4ea14
Change the ReferenceAssembly Nuget Package Ids
dellis1972 63a76a9
Remove commented out code
dellis1972 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "version": 1, | ||
| "isRoot": true, | ||
| "tools": { | ||
| "jetbrains.refasmer.clitool": { | ||
| "version": "1.0.33", | ||
| "commands": [ | ||
| "refasmer" | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
Tools/MonoGame.Framework.Content.Pipeline.Ref/MonoGame.Framework.Content.Pipeline.Ref.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <Project Sdk="Microsoft.Build.NoTargets/2.0.1"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <BaseOutputPath>..\..\Artifacts\MonoGame.Framework.Content.Pipeline.Ref</BaseOutputPath> | ||
| <AppendTargetFrameworkToOutputPath>False</AppendTargetFrameworkToOutputPath> | ||
| <Description>The MonoGame Content Pipeline reference assemblies for all platforms.</Description> | ||
| <PackageTags>monogame;.net core;core;.net standard;standard;</PackageTags> | ||
| <PackageId>MonoGame.Framework.Content.Pipeline.Ref</PackageId> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <None Include="$(BaseOutputPath)\MonoGame.Framework.Content.Pipeline.dll" PackagePath="lib\$(TargetFramework)" Pack="true" /> | ||
| </ItemGroup> | ||
| </Project> |
13 changes: 13 additions & 0 deletions
13
Tools/MonoGame.Framework.Ref/MonoGame.Framework.Ref.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <Project Sdk="Microsoft.Build.NoTargets/2.0.1"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <BaseOutputPath>..\..\Artifacts\MonoGame.Framework.Ref</BaseOutputPath> | ||
| <AppendTargetFrameworkToOutputPath>False</AppendTargetFrameworkToOutputPath> | ||
| <Description>The MonoGame reference assemblies for all platforms.</Description> | ||
| <PackageTags>monogame;.net core;core;.net standard;standard;</PackageTags> | ||
| <PackageId>MonoGame.Framework.Ref</PackageId> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <None Include="$(BaseOutputPath)\MonoGame.Framework.dll" PackagePath="lib\$(TargetFramework)" Pack="true" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
|
|
||
| namespace BuildScripts; | ||
|
|
||
| [TaskName("Build ReferenceAssemblies")] | ||
| [IsDependentOn(typeof(BuildContentPipelineTask))] | ||
| [IsDependentOn(typeof(BuildDesktopGLTask))] | ||
| public sealed class BuildReferenceAssembliesTasks : FrostingTask<BuildContext> | ||
| { | ||
| public override bool ShouldRun(BuildContext context) => context.IsToolInstalled("jetbrains.refasmer.clitool"); | ||
| public override void Run(BuildContext context) { | ||
| // generate a reference assembly for DesktopGL and Pipelines | ||
| context.StartProcess ( | ||
| "dotnet", | ||
| new ProcessSettings() | ||
| { | ||
| Arguments = $"refasmer -v --public -O Artifacts/MonoGame.Framework.Ref -c Artifacts/MonoGame.Framework/DesktopGL/{context.DotNetPackSettings.Configuration}/MonoGame.Framework.dll", | ||
| RedirectStandardOutput = true | ||
| }, | ||
| out IEnumerable<string> processOutput | ||
| ); | ||
| context.StartProcess ( | ||
| "dotnet", | ||
| new ProcessSettings() | ||
| { | ||
| Arguments = $"refasmer -v --public -O Artifacts/MonoGame.Framework.Content.Pipeline.Ref -c Artifacts/MonoGame.Framework.Content.Pipeline/{context.DotNetPackSettings.Configuration}/MonoGame.Framework.Content.Pipeline.dll", | ||
| RedirectStandardOutput = true | ||
| }, | ||
| out processOutput | ||
| ); | ||
| context.DotNetPack(context.GetProjectPath(ProjectType.Tools, "MonoGame.Framework.Ref"), context.DotNetPackSettings); | ||
| context.DotNetPack(context.GetProjectPath(ProjectType.Tools, "MonoGame.Framework.Content.Pipeline.Ref"), context.DotNetPackSettings); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the artifacts folder be called with a starting small letter was intentional on my part, I wanted to slowly resort the repo into:
etc. instead of our current setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change this because it was inconsistent across the repo. I'll have to update all the references to use lowercase if that is the intention, Not sure how this worked with mixed case on Linux in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yea, I forgot we use the artifacts folder for the build output as well.
I guess I'll try to fix it up tomorrow in a separate PR.