Issue #6661: Moved content writing from Flush to new method FinalizeContent #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for maintainers: tests must be run against this PR. |
Mindfulplays
reviewed
Apr 5, 2024
| /// <summary> | ||
| /// Clears buffer using BinaryWriter's flush method | ||
| /// </summary> | ||
| public override void Flush() |
There was a problem hiding this comment.
Do we need this anymore? If it's defaulting to the virtual base call anyways.
There was a problem hiding this comment.
If all it's doing is calling the base, then it's not needed
There was a problem hiding this comment.
I can certainly go and delete it if it's only calling base and has no other purpose
There was a problem hiding this comment.
Deleted! Apologies for the delay.
There was a problem hiding this comment.
I am not a maintainer so you would need to ping @harry-cpp / @mrhelmut to review the PR(s).
Flush called base.Flush() exclusively, no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for Issue #6661
Moves the previous code writing content in Flush() to new method FinalizeContent() and calls it in ContentCompiler method Compile() before calling Flush().