Bring back tests for iOS, update to dotnet 6+, ensure works on device/simulator #8099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonoGame 3.8 Release
Update master
Fix Missing Android Package
In other `Platform` classes (such as `SDLGamePlatform` and `AndroidGamePlatform`, `Threading.Run()` is called during `Tick()` or `RunLoop()` (inconsistently, it may be called before or after `Game.Tick()` unfortunately). Fixing this for `iOSGamePlatform`. `WinForms` and perhaps other platforms (Switch?) may suffer from the same issue. Note that texture loading from background thread is discouraged however a lot of computationally intensive operations (reading/decoding the image file streams, allocating CPU buffers) could be done in the background thread and hence is a good practice to move such work alone into the bgthread until we request the actual texture from the main thread.
- Add/update to netx.0-ios (for now using .net 6 as .net 8 just got released) - Using a base Sample project created from iOS VS template - Remove non-working/incomplete stuff (TextureColorScaling)
…e project instead of the old TFM style
added 3 commits
November 27, 2023 16:54
- Update to .net6.0+ (for now using .net7.0 until .net8.0 is widely deployed elsewhere) - Ensure code compiles (`Color` type collision; newer iOS type names that needed updating; remove `Exit` but still maintain functionality by recreating the main page) etc Two existing interactive tests made to work (one test is old uses keyboard input - which does not work any longer). Will add more tests here. This might be a good framework to add more mobile tests centrally in the future? (Android/iOS/WASM targets?)
|
@SimonDarksideJ @mrhelmut @harry-cpp Please take a look. |
This was referenced Nov 28, 2023
Closed
- Update to .net6.0+ (for now using .net7.0 until .net8.0 is widely deployed elsewhere) - Ensure code compiles (`Color` type collision; newer iOS type names that needed updating; remove `Exit` but still maintain functionality by recreating the main page) etc Two existing interactive tests made to work (one test is old uses keyboard input - which does not work any longer). Will add more tests here. This might be a good framework to add more mobile tests centrally in the future? (Android/iOS/WASM targets?)
…g for `isHighFrequency`. - Also consistently use `high-frequency` instead of `coalesced` when referring to this new behavior.
…into ios-touch
|
Note to self: Once #8092 is in, ensure new interactive high-frequency touch event test is added. |
|
@tomspilman @harry-cpp if you don't mind reviewing this, thanks! |
|
@SimonDarksideJ too, as they were actually planning on adding the test runs in the lab (excited!) |
|
Superceded by #8110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make iOS interactive tests work
Colortype collision; newer iOS type names that needed updating; removeExitbut still maintain functionality by recreating the main page) etcTwo existing interactive tests made to work (one test is old uses keyboard input - which does not work any longer).
Will add more tests to this project.
This might be a good framework to add more mobile tests centrally in the future? (Android/iOS/WASM targets?)