fix: query GL_MAX_SAMPLES before setting multisampling hint #8087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically fixes cases where
MultiSampleCount
is set to something like 16 on a build for Desktop GL and then is run on weaker hardware like a Steam Deck whereGL_MAX_SAMPLES
is 8.Games do not have an API to query for this information to set a valid value for
MultiSampleCount
so the error is effectively unrecoverable and extremely hard to diagnose.The exceptions currently thrown are only symptoms of the issue, they don't expose the actual failure which in this case needed to be queried for via
SDL_GetError()
.