Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default_factory for inner data class #116

Closed
wants to merge 2 commits into from

Conversation

chajath
Copy link

@chajath chajath commented May 12, 2023

In python 3.11, it will fail otherwise

In python 3.11, it will fail otherwise
@SGenheden
Copy link
Contributor

Thanks for this. We became aware of this bug a few days ago.

@codecov-commenter
Copy link

Codecov Report

Merging #116 (e3a4e05) into master (ead1aa2) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          65       65           
  Lines        4927     4927           
  Branches      810      810           
=======================================
  Hits         4114     4114           
  Misses        620      620           
  Partials      193      193           
Impacted Files Coverage Δ
aizynthfinder/context/config.py 95.91% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SGenheden
Copy link
Contributor

Fixed in #141

@SGenheden SGenheden closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants