Fix php 8.2 dynamic properties. Thanks to GitHub user @daveromsey for the submission. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm no longer at MinnPost, and I don't think anyone is currently working on the plugin, but I'll try to take a look at this over the weekend and approve it and get a small release out. Hopefully soon! |
jonathanstegall
changed the title
jonathanstegall
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds property declarations to classes in order to clean up some of the deprecation warnings that have cropped up after upgrading to PHP 8.2.
How do I test this Pull Request?
Load the plugin and view the error log. This PR will clean up the deprecation notices for dynamic properties. There are still some other deprecations for other things, but I wanted to limit the scope of this PR and also make sure I didn't break anything :)