Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small adjustments to the theme for site messages plugin update #76

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

rybridge
Copy link
Contributor

Small adjustments to the theme and how it interacts with the site messages plugin.

  • Adds the popup region below the tag
  • Register the region
  • Adjust homepage middle markup. This markup was moved into the plugin itself
  • Sets up our cookie for "session" tracking
  • Registers Session count in the admin for the conditional criteria
  • Removed the site header file. It seems pretty much the same as the file that was in the plugin. But maybe I'm wrong
  • Not sure how that spacing adjustment happened in the normalize.scss file, but just left it.

@jonathanstegall
Copy link
Member

Tagging issue #21, as this is part of it.

@rybridge
Copy link
Contributor Author

rybridge commented Jan 6, 2020

Anything else I need to look at here or is this approved? Not sure how to proceed since it got tagged as a part of an issue.

@rybridge rybridge merged commit f4d74df into master Jan 7, 2020
@rybridge rybridge deleted the feature/theme-adjustments-for-messages-plugin branch January 7, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants