Added Boat #592
Added Boat #592
Conversation
Added benefit for boats to make them useful
Litorom
requested review from
Makkkkus,
BenCheung0422 and
ChristofferHolmesland
|
Ah, CodeQL reminds you that the input system has been changed, do consider syncing your branch to solve this. |
|
Right, you'll also have to modify your code to use the new input system. |
|
What about following the rule of "everything costs stamina"? Using boat on water still costs stamina, but it consumes stamina per a certain distance travelled continuously. |
| import minicraft.gfx.Screen; | ||
| import minicraft.gfx.SpriteLinker; | ||
|
|
||
| public class RideableEntity extends Entity { |
There was a problem hiding this comment.
Why does this class exist? It does nothing different from Boat.
| return !stopped; | ||
| } | ||
|
|
||
| public boolean move2(double xa, double ya) { |
There was a problem hiding this comment.
move and move2 should probably use the corresponding methods in the Entity class.
| public Boat clone() { | ||
| return new Boat(); | ||
| } | ||
| } |
There was a problem hiding this comment.
This class must probably override the die() method to make sure dying works as intentional.
|
|
||
| private int tickTime = 0; | ||
|
|
||
| private Direction pushDir = Direction.NONE; // the direction to push the furniture |
There was a problem hiding this comment.
Check if the fields above are already defined in the Entity class.
|
For people interested, this is my version of implementation for boat: https://github.com/BenCheung0422/minicraft-plus-revived/tree/boat |
The ultimate and so useful feature has been added. Introducing the boat, the float on water that consumes no stamina!
All jokes aside:
Additions:
Notes: