Standardize tile explosion functions by TNT and creeper #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenCheung0422
force-pushed
the
patch-44
branch
from
5986223
to
b8f18fd
Compare
ChristofferHolmesland
previously approved these changes
Aug 23, 2023
|
Can't you just copy the blacklist over from the tnt to the creeper? There might be cases where we want them to be different. |
|
The power of explosion should be the same as many of these are made of obsidian (inconsistence in tile hardness) and there has already the difference in radius of explosion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from #372. The original problem is that in explosion blacklists of TNT and creeper are differ from each other, so the lists are grouped together with
Tiles#explosionBlacklist. Also, some missing obsidian tiles in the blacklist are added. As the blacklist is standardized, the tile explosion behaviour should also be standardized. The behaviour is standardized by a kind of tile entity,ExplosionTileTicker, with exploded tile replacements and removals (back to hole tiles or infinite fall tiles). Originally, creeper does not explode with exploded tiles and instead instant breaks (replacing with hole tiles and infinite fall tiles).