New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix order of accounts in ledger coinbase witness #15267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order needs to be the same than the transaction application
!ci-build-me |
nholland94
reviewed
Mar 4, 2024
nholland94
reviewed
Mar 4, 2024
nholland94
approved these changes
Mar 4, 2024
!ci-build-me |
!approved-for-mainnet |
sebastiencs
approved these changes
Mar 4, 2024
7 tasks
georgeee
reviewed
Mar 13, 2024
List.map account_ids ~f:(fun acct_id -> (acct_id, access_status)) | ||
|> List.rev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this whole piece after let access_status
definition can be simplified as something like:
let fee_transfer =
let%map.Option transfer = t.fee_transfer in
(Fee_transfer.receiver transfer, access_status)
in
Option.value_map ~default:ident ~f:List.cons fee_transfer [(receiver t, access_status)]
Current code is a bit hard to read
CC @mrmr1993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #13860 onto
berkeley
, and adds a test that passes only when the fix is applied. All credit goes to @sebastiencs.Checklist: