Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves 'RemoteAddress' description for '*-NetFirewall*' cmdlets on supported OSes #3746

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

exchange12rocks
Copy link
Contributor

@exchange12rocks exchange12rocks commented Feb 14, 2024

PR Summary

Clearly specifies what possible inputs for this parameter are accepted on each operating system.
Only for "*-NetFirewall*" cmdlets. Only for the currently supported OSes (WS 2016/2019/2022/2025, W10/11).

Previously some descriptions showed examples of IP address ranges in an incorrect format: "1.2.3.4 through 1.2.3.7"
I also added a new keyword "CaptivePortal" to those OS that support it (note, while W10 supports this keyword, WS2019 doesn't).

I also made sure that information about appending 4/6, using Get-NetFirewallAddressFilter appears in all these documents and is nicely formatted.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

Copy link
Contributor

Learn Build status updates of commit 8be4aa8:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/netsecurity/New-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/netsecurity/Set-NetFirewallAddressFilter.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/netsecurity/Set-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/netsecurity/New-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/netsecurity/Set-NetFirewallAddressFilter.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/netsecurity/Set-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/netsecurity/New-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/netsecurity/Set-NetFirewallAddressFilter.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/netsecurity/Set-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2025-ps/netsecurity/New-NetFirewallRule.md ✅Succeeded View (WindowsServer2025-ps)
docset/winserver2025-ps/netsecurity/Set-NetFirewallAddressFilter.md ✅Succeeded View (WindowsServer2025-ps)
docset/winserver2025-ps/netsecurity/Set-NetFirewallRule.md ✅Succeeded View (WindowsServer2025-ps)

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant