Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new example to New-SelfSignedCertificate #3606

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ehmiiz
Copy link

@ehmiiz ehmiiz commented Aug 23, 2023

PR Summary

The New-SelfSignedCertificate documentation lacks an example of how to provide multiple key usages to the cmdlet.
This PR adds an example that does that.

Prior to this PR, the only way of knowing how to provide multiple values to the -KeyUsage parameter, is to understand the parameter syntax, and many IT Admins look for the examples to solve their problem.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 04d4655:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/pki/New-SelfSignedCertificate.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 73a3776:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/pki/New-SelfSignedCertificate.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review - @ehmiiz, kindly commit the minor suggested change. Many thanks.

ehmiiz and others added 2 commits August 31, 2023 15:57
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 437727f:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/pki/New-SelfSignedCertificate.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 9ae3ce6:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/pki/New-SelfSignedCertificate.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 0c2648a:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/pki/New-SelfSignedCertificate.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

```powershell
$params = @{
Type = 'Custom'
Subject = 'CN=Patti Fuller,OU=UserAccounts,DC=corp,DC=contoso,DC=com'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Subject = 'CN=Patti Fuller,OU=UserAccounts,DC=corp,DC=contoso,DC=com'
Subject = 'CN=Megan Bowen,OU=UserAccounts,DC=corp,DC=contoso,DC=com'

Subject = 'CN=Patti Fuller,OU=UserAccounts,DC=corp,DC=contoso,DC=com'
TextExtension = @(
'2.5.29.37={text}1.3.6.1.5.5.7.3.2',
'2.5.29.17={text}upn=pattifuller@contoso.com' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'2.5.29.17={text}upn=pattifuller@contoso.com' )
'2.5.29.17={text}upn=meganb@contoso.com' )

Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions thanks

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e533039:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/pki/New-SelfSignedCertificate.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New example for New-SelfSignedCertificate, clarifies the KeyUsage parameter
4 participants