Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paragraph "using server variables in rewrite rules" #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cezus
Copy link

@Cezus Cezus commented Oct 15, 2018

What is described in paragraph "using server variables in rewrite rules" is not correct. The information In the list about http headers is not correct. A dash in the http header is not converted to an underscore. It should be stated that de underscore from the condition input is converted to a dash. When the statement from the text was true, I could handle a HTTP header with an underscore in it.

What is described in paragraph "using server variables in rewrite rules" is not correct. The information In the list about http headers is not correct. A dash in the http header is not converted to an underscore. It should be stated that de underscore from the condition input is converted to a dash. When the statement from the text was true, I could handle a HTTP header with an underscore in it.
@Cezus
Copy link
Author

Cezus commented Oct 15, 2018

I just found the page where it is correctly stated: https://docs.microsoft.com/en-us/iis/extensions/url-rewrite-module/url-rewrite-module-20-configuration-reference#accessing-response-headers-from-rewrite-rules

"All underscore ("_") symbols in the name are converted to dash symbols ("-")."

@lextm
Copy link
Contributor

lextm commented Oct 15, 2018

@Cezus You are wrong. This paragraph is talking about incoming requests, while the one you linked is about "responses".

@Cezus
Copy link
Author

Cezus commented Oct 15, 2018

@Cezus You are wrong. This paragraph is talking about incoming requests, while the one you linked is about "responses".

You are right, that article does not apply in this matter. But the problem I try to address is still valid. The problem is as following: https://stackoverflow.com/questions/52816655/how-can-url-rewrite-match-http-headers-with-underscores

@Rick-Anderson
Copy link
Contributor

@John-Hart please review

@John-Hart
Copy link
Contributor

@ning51 could you please verify this?

Copy link

@ning51 ning51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph talks about naming convention of server variables, and it is correct. You may consider add the proposed content at the end of the section "Using server variables in rewrite rules" with an example.

@Rick-Anderson
Copy link
Contributor

@ning51 @John-Hart if this is an improvement, can I S&M. @ning51 can create an issue to track the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants