feat(decorators): support registering arg by createParameterDecorator
#1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalLytek
added
Enhancement 🆕
russell-dot-js
approved these changes
May 3, 2024
MichalLytek
force-pushed
the
support-arg-in-custom-decorator
branch
from
4676270
to
a39482b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aiming to solve #1325.
It's based on #1330 PR by @russell-dot-js 🙌
Unfortunately, after #1400 that PR contained a lot of conflicts, and I was unable to push a commit with fixes into the upstream repo.
There are some differences between this PR and #1330.
Mainly, the signature of the
createParamDecoratorhas been simplified and nowargoptions are the second argument of this function.It also renames
createParamDecoratortocreateParameterDecorator(v2 can have breaking changes).The
returnTypeFunckey has been changed totypeFuncas we describe the input type (I still need to adjust other decorators' signature).Additionally, docs has been updated to reflect the new feature, so do the examples.
And there's now an entry to changelog about this.