Support compression after serialization, fix #173 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compress flag to configuration to support compressing the binary content after serialization
compression was available for json as seperate serializer, but in order to support compression for additional serializers (like protobuf that was requested in #173) it should be a available as a seperate flag
In order to maintain backward compatibility for old configuration file when choosing the json gz serializer option it's using the regular json serializer and use turn on the compression flag
It should be considered to make this change a breaking change
This is my first contribution to this repo and it was a relatively a big assignment because of the additional configuration flag, so I probably missed something - please let me know!