Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Protobuf Serializer] Pooled arrays via Microsoft.IO.RecyclableMemoryStream #305

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

[Protobuf Serializer] Pooled arrays via Microsoft.IO.RecyclableMemoryStream #305

wants to merge 6 commits into from

Conversation

ndrwrbgs
Copy link

My largest concerns I foresee and defer to @MichaCo on the changes that should/should not be made:

  • Deviation from current centralized version
  • CLS Compliance, not familiar with the feature, but RecyclableMemoryStreamManager is NOT this [/ProtoBufSerializer.cs line 30]
  • Coupling of copyright update/license with this change

@ndrwrbgs ndrwrbgs changed the title Feature/pooled arrays [Protobuf Serializer] Pooled arrays via Microsoft.IO.RecyclableMemoryStream Feb 28, 2020
@ndrwrbgs
Copy link
Author

microsoft/Microsoft.IO.RecyclableMemoryStream#85

@ndrwrbgs
Copy link
Author

Fixes ndrwrbgs/CacheManager-Collection#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ndrwrbgs