Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/messagepack serializer #230

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

walter-psjr
Copy link

This PR adds the package to support MessagePack serialization. Referent to #229.

@MichaCo
Copy link
Owner

MichaCo commented May 8, 2018

@walter-psjr
I did read a little bit about the library you are using. The only (or main) extension point of that library are the different resolvers, right?

So, I think that should be a configuration point for this implementation, too. You are currently basically hardcoding it to use ContractlessStandardResolverAllowPrivate.

You can pass objects to serializers in CacheManager, custom configuration or anything, see JsonSerializer for example.
The configuration extensions could take an optional resolver instance which defaults to what you have right now...

What do you think?

@MichaCo
Copy link
Owner

MichaCo commented May 8, 2018

Before I review the PR, could you please squash your commits so that the changes do not show up twice in the changed files?
Thanks! ;)

Implementation

Implementation

Tests fix

Tests fix
@walter-psjr walter-psjr force-pushed the feature/messagepack_serializer branch from 9e9b3d4 to ffbbe6a Compare May 10, 2018 03:19
@walter-psjr
Copy link
Author

Hi @MichaCo, I'm sorry for the delay in answering. I did the commits squash. I left this configuration of the contracts static because I had problems with running the tests and internal classes. I'll take another look, I saw that other people had problems with tests but said that this was solved in the library in December. Thanks for the feedback, I'll try to see this as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants