Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor 3.0 compatibility #26

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Meteor 3.0 compatibility #26

wants to merge 28 commits into from

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Dec 21, 2023

This is the base branch to make this package Meteor 3.0 compatible

Since this is a breaking change, we should also update this package to not define any globals anymore!

Copy link
Member

@harryadel harryadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I expected that you'd drop some packages from tests which is what happened. The testing of these package is really weird and annoying since it relies on sibling packages to see if the library works with them.

@jankapunkt
Copy link
Member Author

I only dropped ongoworks:secrutiy and lai:document-methods as they are out of reach for us. However, I contacted the owners for transfer so we can soon include them back,

@harryadel
Copy link
Member

Thanks @jankapunkt

@jankapunkt
Copy link
Member Author

Published 1.0.0-beta300.2

@jankapunkt
Copy link
Member Author

@StorytellerCZ @harryadel tests are fixed and run for 3.x AND 2.x

package.js Show resolved Hide resolved
@jankapunkt
Copy link
Member Author

@harryadel @StorytellerCZ I fixed all tests that crashed due to dependency issues and released 1.0.0-beta300.2 for testing. You can use it in your apps and it should work out well with latest collection2, too!

Copy link
Member

@harryadel harryadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to block this PR but please give a careful thought to my comments, thank you :)

- '2.8.0'
- '2.14'
# Latest version
- '3.0-beta.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to use the latest RC instead of the beta. This goes for all places that a meteor version is used.

## 1.0

### Functionality
- BREAKING!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful, thank you <3

babel-compiler@7.7.0
babel-runtime@1.5.0
accounts-base@2.2.9
aldeed:collection2@4.0.0-beta.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest collection2 version is about to be 4.0.2 ;)

@@ -1,3 +1,4 @@
{ CollectionExtensions } = require('meteor/lai:collection-extensions')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be possible to rework this coffee script file into vanilla JS? This goes well with the spirit of a new breaking versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants