Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling a missing photo in photo field #3410

Merged
merged 6 commits into from
May 14, 2024
Merged

Handling a missing photo in photo field #3410

merged 6 commits into from
May 14, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented May 6, 2024

Indication of the missing photo

Partially fixes #3405

@saberraz
Copy link
Contributor

saberraz commented May 6, 2024

Thanks Vitor for fixing this issue. Don't we need to show a message about the old photo not being available and if the user does not take any action (i.e. take a new photo or attach one from gallery) we still keep the link between the missing photo and feature. The user might want to fix the issue by restoring the photo from elsewhere (e.g. uploading it through the plugin).

@VitorVieiraZ VitorVieiraZ changed the title Handling a missing photo in photo field WIP - Handling a missing photo in photo field May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Pull Request Test Coverage Report for Build 8969989879

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 60.108%

Totals Coverage Status
Change from base Build 8935477302: 0.06%
Covered Lines: 7665
Relevant Lines: 12752

💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Handling a missing photo in photo field Handling a missing photo in photo field May 6, 2024
@VitorVieiraZ
Copy link
Contributor Author

Thanks Vitor for fixing this issue. Don't we need to show a message about the old photo not being available and if the user does not take any action (i.e. take a new photo or attach one from gallery) we still keep the link between the missing photo and feature. The user might want to fix the issue by restoring the photo from elsewhere (e.g. uploading it through the plugin).

You’re welcome! The message is now applied when the photo is missing. The user has two options: either click on the trash button to remove the missing file from the feature, or fix it, and then the file will be displayed normally when they open the app again.

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning message looks good, but I need to dive deeper into the code to check the internal.absolutrImagePath assignement

@tomasMizera tomasMizera self-requested a review May 14, 2024 09:20
@tomasMizera tomasMizera merged commit 0de739c into master May 14, 2024
10 of 11 checks passed
@tomasMizera tomasMizera deleted the iss-3405 branch May 14, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to edit a photo field in a form if the photo is missing
3 participants