Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run internet scenario or host game #232

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pavanvo
Copy link

@pavanvo pavanvo commented Aug 3, 2022

this PR solving problems with creation internet scenario

@andy5995
Copy link
Contributor

@pavanvo Could you please explain this change more? What is the problem it's fixing?

@pavanvo
Copy link
Author

pavanvo commented Aug 14, 2022

@andy5995 When we starting to host game, we call the code in "getLocalIPAddressListForPlatform" method, which always cause of problem.
Basically code getifaddrs(&ifap); not always set ifap value, also we need to check ifa->ifa_addr .
It's just standard loop for local network checking, and don't know why it was written incompletely.

Without this checks you can not host game, on the dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants