Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/water waves #187

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feature/water waves #187

wants to merge 2 commits into from

Conversation

titison
Copy link
Contributor

@titison titison commented May 3, 2019

Adding simple water waves to MegaGlest.
See https://forum.megaglest.org/index.php?topic=9949

@andy5995
Copy link
Contributor

andy5995 commented May 4, 2019

I've tested this patch and it works.

I made a local edit to autumn.xml in data to fill in the values @titison listed in this forum post.

here are some demo videos:

This uses the values titi_son suggested
https://www.twitch.tv/videos/420122531

This uses the values waveAmplitude="0.44" waveSpeed="0.033" waveFrequency="0.8"
https://www.twitch.tv/videos/420121425

andy5995
andy5995 approved these changes May 4, 2019
View reviewed changes
Copy link
Contributor

@andy5995 andy5995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titiger
Copy link
Member

titiger commented Nov 1, 2019

waves have same size in oceans and in rivers. Titi_son and me talked about it how to fix it.

@andy5995
Copy link
Contributor

andy5995 commented Nov 1, 2019

Cool. I'm looking forward to it

andy5995 referenced this pull request in Ishmaru/Assault-Command-Mod-for-MG Apr 4, 2020
@Ishmaru
2.7 Command Assault update
eae5ad0 
Major Update to game.
Proper Faction Name
New Models
Unit Rebalancing
@Jammyjamjamman
Copy link
Contributor

Jammyjamjamman commented Jun 27, 2020 •
edited

waves have same size in oceans and in rivers. Titi_son and me talked about it how to fix it.

Did you decide on how to fix this yet @titison and @titiger ?

Looking at the code, it would be quite easy to make it dependent on the depth of the water. If you wanted to make it dependent on the depth and the area of the body of water (more accurate), this would be more difficult.

I think the 2 modifications I'd make before merging this is make the wave amplitude and frequency depth dependent:

  • Greater depths => smaller frequency + bigger amplitude.
  • Smaller depth => larger frequency + smaller amplitude.

This might lead to weird looking waves in rivers with a deep trench, but I think it would be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy5995 andy5995 andy5995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@titison @andy5995 @titiger @Jammyjamjamman